Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Fixes for Github Actions sink #45

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fixes for Github Actions sink #45

merged 1 commit into from
Mar 4, 2020

Conversation

mbarrien
Copy link
Contributor

@mbarrien mbarrien commented Mar 4, 2020

This PR adds fixes based on a previous github actions rotator prototype, and reduces the dependencies in go.mod.

  • Adds response code checks and prints human-friendly errors if response codes aren't as expected
  • Fixes an issue where it would always return an error even on success
  • Adds YAML marshalling
  • Removes explicitly passing in rand.Reader; relies on underlying box.SealAnonymous to provide the crypto.

@mbarrien mbarrien requested a review from edulop91 March 4, 2020 18:31
@mbarrien mbarrien requested a review from a team as a code owner March 4, 2020 18:31
@mahmoudian1
Copy link

Codecov Report

Merging #45 into master will decrease coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   24.10%   23.37%   -0.74%     
==========================================
  Files          15       15              
  Lines         477      492      +15     
==========================================
  Hits          115      115              
- Misses        351      366      +15     
  Partials       11       11              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6121fc...116df9c. Read the comment docs.

@edulop91 edulop91 merged commit 52c2d86 into master Mar 4, 2020
@edulop91 edulop91 deleted the mbarrien/github-fixes branch March 4, 2020 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants