[feature] Rotator can write GitHub Actions secrets #44

edulop91 · 2020-03-04T17:08:51Z

Add a new rotator sink to write github action secrets

Test Plan

Ran local test. TODO: unit tests

References

https://developer.github.com/v3/actions/secrets/

mahmoudian1 · 2020-03-04T17:11:44Z

Codecov Report

Merging #44 into master will decrease coverage by 3.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   27.51%   24.10%   -3.41%     
==========================================
  Files          13       15       +2     
  Lines         418      477      +59     
==========================================
  Hits          115      115              
- Misses        292      351      +59     
  Partials       11       11

Impacted Files	Coverage Δ
pkg/sink/github_actions_env.go	`0.00% <0.00%> (ø)`
pkg/sink/helpers.go	`66.66% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6e610...08f5ecd. Read the comment docs.

codecov-io · 2020-03-04T17:16:45Z

Codecov Report

Merging #44 into master will decrease coverage by 3.4%.
The diff coverage is 12.67%.

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage   27.51%   24.1%   -3.41%     
=========================================
  Files          13      15       +2     
  Lines         418     477      +59     
=========================================
  Hits          115     115              
- Misses        292     351      +59     
  Partials       11      11

Impacted Files	Coverage Δ
pkg/sink/sink.go	`0% <ø> (ø)`	⬆️
pkg/config/config.go	`2.55% <0%> (-0.14%)`	⬇️
pkg/sink/github_actions_env.go	`0% <0%> (ø)`
pkg/sink/circleCi.go	`83.33% <100%> (ø)`	⬆️
pkg/sink/travisCi.go	`54.05% <100%> (-2.47%)`	⬇️
pkg/sink/helpers.go	`66.66% <66.66%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6e610...d8820d0. Read the comment docs.

jgadling

Approved once tests are added

mbarrien · 2020-03-04T17:43:27Z

pkg/sink/sink.go

+	KindBuf                 Kind = "Buffer"
+	KindTravisCi            Kind = "TravisCI"
+	KindCircleCi            Kind = "CircleCI"
+	KindGithubActionsSecret Kind = "GitHubActionsSecret"


Missing marshalling in the MarshalYAML below

mbarrien · 2020-03-04T18:08:20Z

pkg/sink/github_actions_env.go

+			s.repo,
+			encryptedSecret,
+		)
+		return errors.Wrap(err, "could not write encrypted secret to GitHub")


Always returns an error, even on success.

edulop added 2 commits March 4, 2020 10:53

[feature] GitHubActions Env support

0110ff8

test github secrets + readme

08f5ecd

edulop91 requested a review from a team as a code owner March 4, 2020 17:08

edulop91 added the bot/merge label Mar 4, 2020

rename

d8820d0

edulop91 assigned jgadling Mar 4, 2020

jgadling approved these changes Mar 4, 2020

View reviewed changes

czimergebot merged commit b6121fc into master Mar 4, 2020

czimergebot deleted the edu/github-actions branch March 4, 2020 17:37

czimergebot removed the bot/merge label Mar 4, 2020

mbarrien reviewed Mar 4, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Rotator can write GitHub Actions secrets #44

[feature] Rotator can write GitHub Actions secrets #44

edulop91 commented Mar 4, 2020

mahmoudian1 commented Mar 4, 2020

codecov-io commented Mar 4, 2020 •

edited

Loading

jgadling left a comment

mbarrien Mar 4, 2020

mbarrien Mar 4, 2020

[feature] Rotator can write GitHub Actions secrets #44

[feature] Rotator can write GitHub Actions secrets #44

Conversation

edulop91 commented Mar 4, 2020

Test Plan

References

mahmoudian1 commented Mar 4, 2020

Codecov Report

codecov-io commented Mar 4, 2020 • edited Loading

Codecov Report

jgadling left a comment

Choose a reason for hiding this comment

mbarrien Mar 4, 2020

Choose a reason for hiding this comment

mbarrien Mar 4, 2020

Choose a reason for hiding this comment

codecov-io commented Mar 4, 2020 •

edited

Loading