Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

[feature] Rotator can write CircleCI env variables #41

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

edulop91
Copy link
Contributor

No description provided.

@edulop91 edulop91 requested a review from a team as a code owner February 18, 2020 22:45
@mahmoudian1
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   27.27%   27.84%   +0.57%     
==========================================
  Files          12       13       +1     
  Lines         385      413      +28     
==========================================
+ Hits          105      115      +10     
- Misses        269      287      +18     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/sink/circleCi.go 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f7582...f36e618. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.57%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   27.27%   27.84%   +0.57%     
==========================================
  Files          12       13       +1     
  Lines         385      413      +28     
==========================================
+ Hits          105      115      +10     
- Misses        269      287      +18     
  Partials       11       11
Impacted Files Coverage Δ
pkg/sink/travisCi.go 56.52% <ø> (ø) ⬆️
pkg/config/config.go 2.76% <0%> (-0.12%) ⬇️
pkg/sink/sink.go 0% <0%> (ø) ⬆️
pkg/sink/circleCi.go 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f7582...f36e618. Read the comment docs.

README.md Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
edulop and others added 2 commits February 18, 2020 15:27
Co-Authored-By: Ryan King <[email protected]>
@edulop91 edulop91 requested a review from ryanking February 18, 2020 23:30
@mahmoudian1
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   27.27%   27.51%   +0.23%     
==========================================
  Files          12       13       +1     
  Lines         385      418      +33     
==========================================
+ Hits          105      115      +10     
- Misses        269      292      +23     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/sink/circleCi.go 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f7582...a4f184f. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.23%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   27.27%   27.51%   +0.23%     
==========================================
  Files          12       13       +1     
  Lines         385      418      +33     
==========================================
+ Hits          105      115      +10     
- Misses        269      292      +23     
  Partials       11       11
Impacted Files Coverage Δ
pkg/sink/travisCi.go 56.52% <ø> (ø) ⬆️
pkg/config/config.go 2.68% <0%> (-0.19%) ⬇️
pkg/sink/sink.go 0% <0%> (ø) ⬆️
pkg/sink/circleCi.go 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f7582...a4f184f. Read the comment docs.

@edulop91 edulop91 merged commit a899454 into master Feb 19, 2020
@edulop91 edulop91 deleted the edu/circleci-env-sink branch February 19, 2020 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants