-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧰 Frontend Infrastructure and Tooling 🛠️ #3
Merged
codemonkey800
merged 22 commits into
chanzuckerberg:main
from
codemonkey800:jeremy/frontend-infra
Apr 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
462bb39
Project dependencies
codemonkey800 62063bc
Setup .nvmrc
codemonkey800 e9d569b
Node.js gitignore
codemonkey800 584c7fa
Setup initial next.js app
codemonkey800 2906f62
Added SSR for React Query
codemonkey800 3a08feb
Added Tailwind CSS and JIT
codemonkey800 e6c6551
Added script for generating types for SCSS modules
codemonkey800 225fffd
Setup Jest + React Testing Library for unit tests
codemonkey800 b53b4ed
Setup Jest + Playwright for E2E tests
codemonkey800 cc6cb86
Added prettier config
codemonkey800 a5f04a9
Added stylelint config
codemonkey800 7d21dfd
Added ESLint configs
codemonkey800 b3bcb72
Added lint-staged and husky for linting on commit
codemonkey800 57dd9ec
Added plopfile for component and page generators
codemonkey800 909cd0e
Added recommended VSCode extensions and settings
codemonkey800 8953850
Added client README.md
codemonkey800 5486951
Swap pnpm for yarn
codemonkey800 398b274
Rename bg-napari-app-bar to bg-napari-primary
codemonkey800 c92b293
Added link to client/README.md in root README.md
codemonkey800 1177252
Minor refactors
codemonkey800 520a10b
Address review comments
codemonkey800 1b838b3
Fix vscode settings and add spell checker extension
codemonkey800 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I love that pnpm is growing significantly and is up to 2x faster than competitors, it still doesn't have Dependabot support.
Dependabot has support for parsing and updating the
yarn.lock
file, which is crucial for detecting and fixing security vulnerabilities. When Dependabot gets support for thepnpm-lock.yaml
files, we can revisit swapping Yarn for pnpm.