Skip to content

Commit

Permalink
review dog hasnt been running bc the trigger was push and it only run…
Browse files Browse the repository at this point in the history
…s on pr
  • Loading branch information
hspitzley-czi committed Feb 23, 2024
1 parent 83a7cc3 commit fa43a12
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 35 deletions.
44 changes: 10 additions & 34 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
on: push
on:
- pull_request

name: CI

Expand All @@ -17,7 +18,7 @@ jobs:
id: changedGoPackages
uses: ./.github/actions/find-changed-packages

run:
run-ci:
runs-on: [ARM64, self-hosted, Linux]
needs: find-changed-packages
if: ${{ needs.find-changed-packages.outputs.changedPackages != '[]' }}
Expand All @@ -29,38 +30,6 @@ jobs:
- lint-ci

steps:
# - name: Generate token
# id: generate_token
# uses: chanzuckerberg/[email protected]
# with:
# app_id: ${{ secrets.CZI_GITHUB_HELPER_APP_ID }}
# private_key: ${{ secrets.CZI_GITHUB_HELPER_PK }}
# - uses: actions/checkout@v4
# with:
# token: ${{ steps.generate_token.outputs.token }}
# ref: ${{ github.event.pull_request.head.ref }}
# - uses: actions/setup-go@v5
# with:
# go-version-file: ${{ matrix.gopkg }}/go.mod
# cache: true
# - name: Run tests
# run: make test-ci
# working-directory: ${{ matrix.gopkg }}
# - name: golangci-lint
# uses: golangci/golangci-lint-action@v3
# with:
# version: v1.54.2
# github-token: ${{ secrets.GITHUB_TOKEN }}
# args: --timeout 10m0s --out-format=tab --fix --config=../.golangci.yml
# working-directory: ${{ matrix.gopkg }}
# skip-pkg-cache: true
# - uses: EndBug/add-and-commit@v9
# id: commit_linter_changes
# with:
# add: -A
# message: ci - linter fixes for ${{ matrix.gopkg }} package


- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
Expand All @@ -74,3 +43,10 @@ jobs:
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: make ${{ matrix.target }}
working-directory: ${{ matrix.gopkg }}

# this job exists to give us something to make a required check on that will ensure all CI runs are complete
run-ci-complete:
runs-on: [ARM64, self-hosted, Linux]
needs: run-ci
steps:
- run: echo "CI runs complete"
2 changes: 1 addition & 1 deletion .github/workflows/mod-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
id: commit_go_mod
with:
add: -A
message: ci - update ${{ matrix.gopkg }} go.mod
message: ci - update ${{ matrix.gopkg }}/go.mod

# this job exists to give us something to make a required check on that will ensure all go.mod updates are complete
go-mod-updates-complete:
Expand Down

0 comments on commit fa43a12

Please sign in to comment.