-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
review dog hasnt been running bc the trigger was push and it only run…
…s on pr
- Loading branch information
1 parent
83a7cc3
commit fa43a12
Showing
2 changed files
with
11 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
on: push | ||
on: | ||
- pull_request | ||
|
||
name: CI | ||
|
||
|
@@ -17,7 +18,7 @@ jobs: | |
id: changedGoPackages | ||
uses: ./.github/actions/find-changed-packages | ||
|
||
run: | ||
run-ci: | ||
runs-on: [ARM64, self-hosted, Linux] | ||
needs: find-changed-packages | ||
if: ${{ needs.find-changed-packages.outputs.changedPackages != '[]' }} | ||
|
@@ -29,38 +30,6 @@ jobs: | |
- lint-ci | ||
|
||
steps: | ||
# - name: Generate token | ||
# id: generate_token | ||
# uses: chanzuckerberg/[email protected] | ||
# with: | ||
# app_id: ${{ secrets.CZI_GITHUB_HELPER_APP_ID }} | ||
# private_key: ${{ secrets.CZI_GITHUB_HELPER_PK }} | ||
# - uses: actions/checkout@v4 | ||
# with: | ||
# token: ${{ steps.generate_token.outputs.token }} | ||
# ref: ${{ github.event.pull_request.head.ref }} | ||
# - uses: actions/setup-go@v5 | ||
# with: | ||
# go-version-file: ${{ matrix.gopkg }}/go.mod | ||
# cache: true | ||
# - name: Run tests | ||
# run: make test-ci | ||
# working-directory: ${{ matrix.gopkg }} | ||
# - name: golangci-lint | ||
# uses: golangci/golangci-lint-action@v3 | ||
# with: | ||
# version: v1.54.2 | ||
# github-token: ${{ secrets.GITHUB_TOKEN }} | ||
# args: --timeout 10m0s --out-format=tab --fix --config=../.golangci.yml | ||
# working-directory: ${{ matrix.gopkg }} | ||
# skip-pkg-cache: true | ||
# - uses: EndBug/add-and-commit@v9 | ||
# id: commit_linter_changes | ||
# with: | ||
# add: -A | ||
# message: ci - linter fixes for ${{ matrix.gopkg }} package | ||
|
||
|
||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
|
@@ -74,3 +43,10 @@ jobs: | |
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: make ${{ matrix.target }} | ||
working-directory: ${{ matrix.gopkg }} | ||
|
||
# this job exists to give us something to make a required check on that will ensure all CI runs are complete | ||
run-ci-complete: | ||
runs-on: [ARM64, self-hosted, Linux] | ||
needs: run-ci | ||
steps: | ||
- run: echo "CI runs complete" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters