Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AWS Account ID to fogg init interview #837

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

dspadea
Copy link
Contributor

@dspadea dspadea commented Apr 20, 2023

Fogg requires the AWS Provider's AccountID to be set in the default configuration. The fogg init interview does not ask for this account ID, so the fogg.yml file produced is immediately invalid. Users trying to create a new fogg project are greeted with an error when running any subsequent command.

This PR adds AWS Account ID to the interview for the initial fogg.yml file so fogg subsequently works properly.

@dspadea dspadea changed the title FIX: Add AWS Account ID to fogg init interview fix: Add AWS Account ID to fogg init interview Apr 20, 2023
config/config.go Outdated Show resolved Hide resolved
init/init_test.go Outdated Show resolved Hide resolved
config/config.go Show resolved Hide resolved
@dspadea dspadea marked this pull request as ready for review April 20, 2023 22:18
@dspadea dspadea requested a review from a team as a code owner April 20, 2023 22:18
@dspadea dspadea requested a review from alexlokshin-czi April 20, 2023 22:18
@dspadea dspadea merged commit 1f66cd3 into main Apr 20, 2023
@dspadea dspadea deleted the dspadea/add_aws_account_id branch April 20, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants