add ability to dump aws/config to stdout #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For running in Atlantis, we need to be able to generate an entire aws/config file non-interactively. This PR will allow you to do that with fogg exp aws-config -a -e -r rolename It also removes the code for generating the profile session name, since that seems to be a dead-end in terms of enforcement.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 17 17
Lines 1408 1408
=======================================
Hits 1127 1127
Misses 160 160
Partials 121 121Continue to review full report at Codecov.
|
|
Looks okay but needs a rebase against the Go modules PR I just merged. |
edulop91
approved these changes
Jun 4, 2019
palasha
pushed a commit
to palasha/fogg
that referenced
this pull request
Apr 7, 2020
add ability to dump aws/config to stdoutFor running in Atlantis, we need to be able to generate an entire aws/config file non-interactively. This PR will allow you to do that with fogg exp aws-config -a -e -r rolename It also removes the code for generating the profile session name, since that seems to be a dead-end in terms of enforcement. ### Test Plan * unit tests, manual test against shared-infra repo ### References
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For running in Atlantis, we need to be able to generate an entire aws/config file non-interactively.
This PR will allow you to do that with fogg exp aws-config -a -e -r rolename
It also removes the code for generating the profile session name, since that seems to be a dead-end in terms of enforcement.
Test Plan
References