Use top-level default settings for global #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 80.01% 80.04% +0.02%
==========================================
Files 17 17
Lines 1406 1408 +2
==========================================
+ Hits 1125 1127 +2
Misses 160 160
Partials 121 121
Continue to review full report at Codecov.
|
ryanking
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the generated fogg output to use the top-level defaults when rendering the terraform_remote_state pointing at "global" component, which make sit properly reflect the bucket and path of the global component instead of getting overridden by any account/component level override.
Note that this may have an effect of using the top-level default AWS profile for global instead of any override too. In the particular case of AWS profile, this may not be the desired behavior.
Test Plan
Existing golden file tests were updated to reflect the correct output. A test case was added to the v2_full staging/comp1 component to reflect an override of the profile at the component level.