deprecate docker support #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 79.29% 79.34% +0.04%
==========================================
Files 16 16
Lines 1304 1307 +3
==========================================
+ Hits 1034 1037 +3
Misses 156 156
Partials 114 114
Continue to review full report at Codecov.
|
mbarrien
approved these changes
May 24, 2019
palasha
pushed a commit
to palasha/fogg
that referenced
this pull request
Apr 7, 2020
deprecate docker supportWe plan on removing support for running via docker in the future. This PR adds a simple mechanism for displaying warnings and adds one about docker support. ### Test Plan * unit tests ### References * Fixes chanzuckerberg#260
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan on removing support for running via docker in the future. This PR adds a simple mechanism for displaying warnings and adds one about docker support.
Test Plan
References