refactor plan to match config #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 78.46% 78.13% -0.34%
==========================================
Files 15 15
Lines 1240 1221 -19
==========================================
- Hits 973 954 -19
Misses 161 161
Partials 106 106
Continue to review full report at Codecov.
|
edulop91
reviewed
May 14, 2019
| @@ -29,6 +30,7 @@ func TestIntegration(t *testing.T) { | |||
| for _, tc := range testCases { | |||
| t.Run(tc.fileName, func(t *testing.T) { | |||
| a := assert.New(t) | |||
| r := require.New(t) | |||
There was a problem hiding this comment.
huh, seems like this is what we'd want to be using in general rather than assert
edulop91
approved these changes
May 14, 2019
palasha
pushed a commit
to palasha/fogg
that referenced
this pull request
Apr 7, 2020
refactor plan to match config### Summary This is a refactoring to make it easier to make AWS providers optional (and add other providers). ### Test Plan All existing tests pass, plus I tested manually on shared-infra.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a refactoring to make it easier to make AWS providers optional (and add other providers).
Test Plan
All existing tests pass, plus I tested manually on shared-infra.