Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] consolidate debug and verbose modes #227

Merged
merged 1 commit into from
May 1, 2019

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented May 1, 2019

Does not seem to be value in having both, going to just have --debug/-d

Fixes #226

Does not seem to be value in having both, going to just have `--debug/-d`
@ryanking ryanking requested a review from a team as a code owner May 1, 2019 17:37
@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   58.94%   58.94%           
=======================================
  Files          11       11           
  Lines         838      838           
=======================================
  Hits          494      494           
  Misses        271      271           
  Partials       73       73
Impacted Files Coverage Δ
apply/apply.go 33.58% <0%> (ø) ⬆️
plan/plan.go 90.81% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2471d...a53a62f. Read the comment docs.

@czimergebot czimergebot merged commit 52bbfbc into master May 1, 2019
@ryanking ryanking deleted the ryanking/debug_verbose branch May 8, 2019 21:46
palasha pushed a commit to palasha/fogg that referenced this pull request Apr 7, 2020
[breaking] consolidate debug and verbose modesDoes not seem to be value in having both, going to just have `--debug/-d`

Fixes chanzuckerberg#226
@vincenthsh vincenthsh mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rationalize debug and verbose
4 participants