Add missing targets to helm_template component makefile #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
commented
Apr 17, 2019
| @@ -25,3 +25,12 @@ set-eks-context: | |||
|
|
|||
| lint: | |||
| @helm lint -f variables.yaml . | |||
|
|
|||
| fmt: | |||
There was a problem hiding this comment.
These are not well defined yet, so leaving a message and moving on. That way we don't break the top level make fmt etc for now
ryanking
approved these changes
Apr 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 11 11
Lines 835 835
=======================================
Hits 495 495
Misses 267 267
Partials 73 73Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.