Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from log to logrus #256

Closed
ryanking opened this issue May 20, 2019 · 0 comments · Fixed by #269
Closed

switch from log to logrus #256

ryanking opened this issue May 20, 2019 · 0 comments · Fixed by #269
Assignees
@ryanking

Comments

@ryanking
Copy link
Contributor

No description provided.

@ryanking ryanking assigned ryanking and unassigned ryanking May 20, 2019
ryanking added a commit that referenced this issue May 24, 2019
@ryanking
switch to using logrus as-is
5ae6852 
Honestly just doing this so that goimports works seamlessly.

Fixes #256
@ryanking ryanking mentioned this issue May 24, 2019
Merged
czimergebot pushed a commit that referenced this issue May 24, 2019
@ryanking @czimergebot
switch to using logrus as-is (#269)
bbda295 
switch to using logrus as-isHonestly just doing this so that goimports works seamlessly.

### Test Plan
Say unittests, or list out steps to verify changes.

### References
* Fixes #256
palasha pushed a commit to palasha/fogg that referenced this issue Apr 7, 2020
@ryanking @palasha
switch to using logrus as-is (chanzuckerberg#269)
a06df7a 
switch to using logrus as-isHonestly just doing this so that goimports works seamlessly.

### Test Plan
Say unittests, or list out steps to verify changes.

### References
* Fixes chanzuckerberg#256
@vincenthsh vincenthsh mentioned this issue Apr 24, 2024
Closed
@vincenthsh vincenthsh mentioned this issue Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanking ryanking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to using logrus as-is chanzuckerberg/fogg
1 participant
@ryanking