upgrade next

[phoenixAja]

Summary:

• What: upgrade Next (In versions of Next.js prior to 12.0.5 or 11.1.3, invalid or malformed URLs could lead to a server crash. In order to be affected by this issue, the deployment must use Next.js versions above 11.1.0 and below 12.0.5)
• Ticket: sc177040
• Env: rdev link

Demos:

Notes:

Checklist:

• I merged latest trunk
• I manually verified the change
• I added labels to my PR
• I tested in multiple browsers
• I added relevant unit tests
• I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

[vincent-czi]

Seems reasonable! My only concern would be if there turns out to be some kind of version issue, but as long as you were able to do some QA and it was clean of any weird behavior, seems good to me.

[vincent-czi]

What's this about?

[phoenixAja]

a little confusing to tell from the docs but this file is regenerated when you run next build, i think it removed that line because that next type is no longer relevant to the typescript compiler with the upgrade

[vincent-czi]

I just needed to docker-compose down then up the containers -- also ran a DB migration, but I don't think that matters -- and this line re-appeared in my next-env.d.ts file.

/// <reference types="next/types/global" />

Maybe we should re-commit it back in? Probably has no impact on how it runs since we build during the CI pipeline, but if it keeps showing up as a dirty file locally that will just be confusing to see.