Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use workflowId instead of phyloTree Id #865

Merged
merged 1 commit into from
Dec 14, 2021
Merged

use workflowId instead of phyloTree Id #865

merged 1 commit into from
Dec 14, 2021

Conversation

phoenixAja
Copy link
Collaborator

Summary:

  • What: switch trees key to use workflowID instead of phyloTreeID (started and failed phyloTrees have no associated phyloTree Ids)
  • Ticket: sc176694
  • Env: <rdev link>

Demos:

Notes:

Checklist:

  • I merged latest trunk
  • I manually verified the change
  • I added labels to my PR
  • I tested in multiple browsers
  • I added relevant unit tests
  • I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

@phoenixAja phoenixAja merged commit dfdae7c into trunk Dec 14, 2021
@phoenixAja phoenixAja deleted the phoenix/phylotree-status-badge-fix branch December 14, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmmmmmaya mmmmmmaya mmmmmmaya approved these changes

@vincent-czi vincent-czi Awaiting requested review from vincent-czi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phoenixAja @mmmmmmaya