Switch to pipenv for dependency management #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think |
ttung
force-pushed
the
ttung/pipenv
branch
2 times, most recently
from
27b6193
to
cbfcecd
Compare
### Description Standard requirements.txt files have a few issues with a third party library installed from source: 1. pip does not handle [relative paths](pypa/pip#8765) in a predictable way. It is relative to current working directory instead of relative to the path of the requirements.txt. As we cannot constrain that, it leads to unpredictable behavior. 2. `pip freeze` does not generate the correct output when there is a local library. ### Test plan 1. tried to deploying to elastic beanstalk, and it seems to work. 2. ran `make update-deps` 3. ran `make update-deps` with a local library and `Pipfile.lock` references that instead of just a version number.
This was referenced Feb 3, 2021
interesting, i would personally like to move towards this approach if we end up doing a deploy solution that's not ebs. |
phoenixAja
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standard requirements.txt files have a few issues with a third party library installed from source:
pip freezedoes not generate the correct output when there is a local library.Test plan
make update-depsmake update-depswith a local library andPipfile.lockreferences that instead of just a version number.