Fix alembic tooling #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2021
|
This pull request has been linked to Clubhouse Story #65314: Standup dummy version of APP + DB for GenEpi MVP. |
lvreynoso
reviewed
Feb 1, 2021
database_migrations/env.py
Outdated
| @@ -1,6 +1,8 @@ | |||
| import os | |||
| from logging.config import fileConfig | |||
|
|
|||
| from sqlalchemy import create_engine | |||
There was a problem hiding this comment.
looks like this appears twice now?
### Description Autogenerate requires the `include_schemas=True` to work. #### Issue [ch65314](https://app.clubhouse.io/genepi/stories/space/65314) ### Test plan Generated some migrations.
lvreynoso
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autogenerate requires the
include_schemas=Trueto work.Issue
ch65314
Test plan
Generated some migrations.