Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ontology_info.json for 5.1 #207

Merged
merged 13 commits into from
May 14, 2024
Merged

feat: update ontology_info.json for 5.1 #207

merged 13 commits into from
May 14, 2024

Conversation

Bento007
Copy link
Collaborator

@Bento007 Bento007 commented May 9, 2024

Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the new EFO release has an unexpected type for "synonym". we'll have to investigate if its an issue with our builder, the release, owlready, or if its valid somehow

@Bento007
Copy link
Collaborator Author

Bento007 commented May 9, 2024

  "EFO:0022503": {
    "ancestors": {
      "EFO:0002888": 1,
      "EFO:0001639": 2,
      "EFO:0000001": 6
    },
    "label": "92-1",
    "description": "Human uveal melanoma",
    "synonyms": [
      92.1
    ],
    "deprecated": false
  }

It looks like something that could easily be a typo. 92.1 could be converted to a string and then it will work fine.

@brianraymor
Copy link

Not commenting on the typing, but it looks like EFO is adding cell lines?

Human uveal melanoma

@brianraymor
Copy link

Typed as decimal?

<oboInOwl:hasExactSynonym rdf:datatype="http://www.w3.org/2001/XMLSchema#decimal">92.1</oboInOwl:hasExactSynonym>

@Bento007
Copy link
Collaborator Author

It's being parsed into a float in python

@nayib-jose-gloria
Copy link
Collaborator

nayib-jose-gloria commented May 10, 2024

  "EFO:0022503": {
    "ancestors": {
      "EFO:0002888": 1,
      "EFO:0001639": 2,
      "EFO:0000001": 6
    },
    "label": "92-1",
    "description": "Human uveal melanoma",
    "synonyms": [
      92.1
    ],
    "deprecated": false
  }

It looks like something that could easily be a typo. 92.1 could be converted to a string and then it work work fine.

I think its probably safe to add a str cast in the builder for anything in synonym, label, description

@Bento007 Bento007 added the 5.1 Next minor CELLxGENE schema version after 5.0 (includes spatial) label May 13, 2024
term_dict[term_id]["synonyms"] = onto_term.hasExactSynonym

if hasExactSynonym := getattr(onto_term, "hasExactSynonym", None):
term_dict[term_id]["synonyms"] = [x if isinstance(x, str) else str(x) for x in hasExactSynonym]
Copy link
Collaborator

@nayib-jose-gloria nayib-jose-gloria May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: any reason not to just [str(x) for x in hasExactSynonym]?

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.26%. Comparing base (1ba810e) to head (6c11b71).

❗ Current head 6c11b71 differs from pull request most recent head f11690e. Consider uploading reports for the commit f11690e to get more accurate results

Files Patch % Lines
...ols/ontology-builder/src/all_ontology_generator.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          18       18           
  Lines        1106     1106           
  Branches      214      215    +1     
=======================================
  Hits          943      943           
  Misses        153      153           
  Partials       10       10           
Flag Coverage Δ
unittests 85.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bento007 Bento007 enabled auto-merge (squash) May 14, 2024 17:36
@Bento007 Bento007 merged commit d5c8ae3 into main May 14, 2024
@Bento007 Bento007 deleted the tsmith/schema_5.1 branch May 14, 2024 17:46
@github-actions github-actions bot mentioned this pull request May 9, 2024
Bento007 pushed a commit that referenced this pull request May 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>python-api: 1.0.0</summary>

##
[1.0.0](python-api-v0.8.0...python-api-v1.0.0)
(2024-05-15)


### Features

* update ontology_info.json for 5.1
([#207](#207))
([d5c8ae3](d5c8ae3))


### Misc

* release 1.0.0
([60eef67](60eef67))
</details>

<details><summary>ontology-assets: 1.0.0</summary>

##
[1.0.0](ontology-assets-v0.5.0...ontology-assets-v1.0.0)
(2024-05-15)


### Features

* update ontology_info.json for 5.1
([#207](#207))
([d5c8ae3](d5c8ae3))


### Misc

* release 1.0.0
([60eef67](60eef67))
* update ontology descendant mappings
([#202](#202))
([b41948b](b41948b))
* update ontology descendant mappings
([#205](#205))
([94157d0](94157d0))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.1 Next minor CELLxGENE schema version after 5.0 (includes spatial)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants