-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update ontology_info.json for 5.1 #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the new EFO release has an unexpected type for "synonym". we'll have to investigate if its an issue with our builder, the release, owlready, or if its valid somehow
It looks like something that could easily be a typo. |
Not commenting on the typing, but it looks like EFO is adding cell lines? |
Typed as decimal?
|
It's being parsed into a float in python |
I think its probably safe to add a str cast in the builder for anything in synonym, label, description |
term_dict[term_id]["synonyms"] = onto_term.hasExactSynonym | ||
|
||
if hasExactSynonym := getattr(onto_term, "hasExactSynonym", None): | ||
term_dict[term_id]["synonyms"] = [x if isinstance(x, str) else str(x) for x in hasExactSynonym] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: any reason not to just [str(x) for x in hasExactSynonym]
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 85.26% 85.26%
=======================================
Files 18 18
Lines 1106 1106
Branches 214 215 +1
=======================================
Hits 943 943
Misses 153 153
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🤖 I have created a release *beep* *boop* --- <details><summary>python-api: 1.0.0</summary> ## [1.0.0](python-api-v0.8.0...python-api-v1.0.0) (2024-05-15) ### Features * update ontology_info.json for 5.1 ([#207](#207)) ([d5c8ae3](d5c8ae3)) ### Misc * release 1.0.0 ([60eef67](60eef67)) </details> <details><summary>ontology-assets: 1.0.0</summary> ## [1.0.0](ontology-assets-v0.5.0...ontology-assets-v1.0.0) (2024-05-15) ### Features * update ontology_info.json for 5.1 ([#207](#207)) ([d5c8ae3](d5c8ae3)) ### Misc * release 1.0.0 ([60eef67](60eef67)) * update ontology descendant mappings ([#202](#202)) ([b41948b](b41948b)) * update ontology descendant mappings ([#205](#205)) ([94157d0](94157d0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Reason for Change