Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tiledbsoma 0.5.0a6 #82

Merged
merged 7 commits into from
Jan 23, 2023

Conversation

atolopko-czi
Copy link
Collaborator

@atolopko-czi atolopko-czi commented Jan 23, 2023

Resolves #81
Resolves #10

Changes

  • Unicode now supported in soma.DataFrame columns.
  • Removed unicode workaround, which forced all unicode values to ASCII.
  • Added explicit test to ensure continued support of unicode.
  • Fix AxisQuery import, now that class is exported by tiledbsoma
  • Replace somacore imports with soma in notebooks

Reviewer Notes:

As some notebook imports were updated, I test ran one only of those notebooks and did not re-run results for any of them.

…nzuckerberg/cell-census into atol/81-update-to-tiledbsoma-0.5.0a6
@atolopko-czi atolopko-czi marked this pull request as ready for review January 23, 2023 18:13
@atolopko-czi atolopko-czi changed the title issue: 81 update to tiledbsoma 0.5.0a6 Jan 23, 2023
Copy link
Contributor

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should do some manual verification of the first Unicode-inclusive Census build so ensure that the handful of non-ASCII strings look reasonable.

- Unicode now supported in soma.DataFrame columns.
- Removed unicode workaround, which forced all unicode values to ASCII.
- Added explicit test to ensure continued support of unicode.
- Fix AxisQuery import, now that class is exported by tiledbsoma
@atolopko-czi atolopko-czi merged commit 060a875 into main Jan 23, 2023
@atolopko-czi atolopko-czi deleted the atol/81-update-to-tiledbsoma-0.5.0a6 branch January 23, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants