Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Slider component #871
Implement Slider component #871
Changes from 8 commits
8dc6694
5b86445
ad03ef6
fc2da38
82e3ce3
be93f0b
91af82c
47f1cd8
0deb2e3
c524278
0ddcc19
df8efde
d4719ab
cab922d
6dbf0e6
cc85f23
5714c95
3c8aab3
bea3d26
b294719
d45d4ac
6da9192
2d75e15
540debc
86a3f2f
a121eec
2932cf6
7caef02
5509d46
2f3b5bd
42965df
2b85ee5
6548bc5
18dec46
bb12fb8
6591ad6
24047d2
691d975
bc7e72e
89c62cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
만약 포커스 디자인이 TextField, TextArea, Select 외에도 범용적으로 사용된다면 Forms/ 디렉토리 하위로 이동해야할 거 같네요 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixins
안에focusedInputWrapperStyle
,erroredInputWrapperStyle
이 두 개는input
외에도 다른 컴포넌트에 사용할 수 있을 것 같아서, 후속 PR에서input
에 사용되는 믹스인과 그렇지 않은 것을 분리하고 적용해야 할 것 같습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: hasError, readOnly prop 지원되면 좋을 것 같습니다. (
FormComponentProps
)