Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch 컴포넌트 구현이 Figma 명세를 따르도록 수정 #848

Merged
merged 6 commits into from
Jul 8, 2022

Conversation

Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Jul 4, 2022

Summary

  • Forms의 Switch 컴포넌트 구현이 Figma 명세를 따르도록 수정합니다.

Details

Closes #840

  • BREAKING CHANGE: size prop은 더 이상 number형이 아닌, 새로 정의한 SwitchSize enum 타입을 사용합니다.
    export enum SwitchSize {
      M = 'm',
      S = 's',
    }
  • Switch 컴포넌트의 width, height, disabled = true 시의 opacity가 명세에 맞게 변경됩니다.
  • border-radiusfoundation.rounding을 사용합니다.
  • Switch 핸들 컴포넌트의 width, height 및 absolute 위치(padding)이 명세에 맞게(2px -> 3px) 변경됩니다.

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

References

@Dogdriip Dogdriip added the refactoring Issue or PR related to refactoring with no functional changes label Jul 4, 2022
@Dogdriip Dogdriip self-assigned this Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #848 (1053fd1) into next-v1 (7d15371) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v1     #848      +/-   ##
===========================================
+ Coverage    68.94%   68.98%   +0.04%     
===========================================
  Files          204      204              
  Lines         2866     2870       +4     
  Branches       787      788       +1     
===========================================
+ Hits          1976     1980       +4     
  Misses         775      775              
  Partials       115      115              
Impacted Files Coverage Δ
...react/src/components/Forms/Switch/Switch.styled.ts 100.00% <100.00%> (ø)
...ezier-react/src/components/Forms/Switch/Switch.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d15371...1053fd1. Read the comment docs.

@sungik-choi sungik-choi self-requested a review July 4, 2022 05:22
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이그레이션이 필요하겠네요

@sungik-choi
Copy link
Contributor

리베이스 후 changeset 추가 부탁드려요!

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

🦋 Changeset detected

Latest commit: 1053fd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi
Copy link
Contributor

Changelog는 영어로 작성해주실 수 있을까요?
제가 관련해서 따로 가이드 만들어두겠습니다 🙏

@Dogdriip Dogdriip requested review from Seolhun and npbg July 8, 2022 04:55
Copy link
Contributor

@Seolhun Seolhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 이야기지만, Switch ref가 inputElement면 좋을것 같은데 아쉽네요.

@Dogdriip
Copy link
Contributor Author

Dogdriip commented Jul 8, 2022

다른 이야기지만, Switch ref가 inputElement면 좋을것 같은데 아쉽네요.

관련해서 #711 에 이미 이슈화되고 어사인받은 게 있어서 염두에 두고 있습니다! 추후에 bezier 전반적으로 접근성 방향성이 잡히고 작업 시작되면 시도해보려 합니다 💪

@Dogdriip Dogdriip merged commit ab31859 into channel-io:next-v1 Jul 8, 2022
@Dogdriip Dogdriip deleted the refactor/switch branch July 8, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issue or PR related to refactoring with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch 컴포넌트가 Figma 명세를 따르도록 개선
4 participants