-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch 컴포넌트 구현이 Figma 명세를 따르도록 수정 #848
Conversation
Codecov Report
@@ Coverage Diff @@
## next-v1 #848 +/- ##
===========================================
+ Coverage 68.94% 68.98% +0.04%
===========================================
Files 204 204
Lines 2866 2870 +4
Branches 787 788 +1
===========================================
+ Hits 1976 1980 +4
Misses 775 775
Partials 115 115
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마이그레이션이 필요하겠네요
리베이스 후 changeset 추가 부탁드려요! |
BREAKING CHANGE: size가 더 이상 number가 아닌 SwitchSize enum type을 받음
🦋 Changeset detectedLatest commit: 1053fd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changelog는 영어로 작성해주실 수 있을까요? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 이야기지만, Switch ref가 inputElement면 좋을것 같은데 아쉽네요.
관련해서 #711 에 이미 이슈화되고 어사인받은 게 있어서 염두에 두고 있습니다! 추후에 bezier 전반적으로 접근성 방향성이 잡히고 작업 시작되면 시도해보려 합니다 💪 |
Summary
Switch
컴포넌트 구현이 Figma 명세를 따르도록 수정합니다.Details
size
prop은 더 이상number
형이 아닌, 새로 정의한SwitchSize
enum 타입을 사용합니다.Switch
컴포넌트의width
,height
,disabled = true
시의opacity
가 명세에 맞게 변경됩니다.border-radius
를foundation.rounding
을 사용합니다.Switch
핸들 컴포넌트의width
,height
및 absolute 위치(padding)이 명세에 맞게(2px -> 3px) 변경됩니다.Browser Compatibility
OS / Engine 호환성을 반드시 확인해주세요.
Windows
macOS
References