build(rollupconfig): aliasing 적용 후 타입이 올바르게 생성되지 않던 문제를 수정 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rollup/plugin-alias를 제거하고 rollup-plugin-typescript2 를 사용하게 수정
Codecov Report
@@ Coverage Diff @@
## next-v1 #668 +/- ##
========================================
Coverage 57.27% 57.27%
========================================
Files 152 152
Lines 2434 2434
Branches 684 684
========================================
Hits 1394 1394
Misses 938 938
Partials 102 102
Continue to review full report at Codecov.
|
aooen
approved these changes
Dec 15, 2021
inhibitor1217
approved these changes
Dec 15, 2021
quino0627
commented
Dec 15, 2021
Comment on lines
+30
to
+40
| exclude: [ | ||
| './src/index.ts', | ||
| './src/components/Icon/generated/**/*', | ||
| './src/layout/stories/**/*', | ||
| '**/*.stories.tsx', | ||
| '**/*.test.ts', | ||
| '**/*.test.tsx', | ||
| './src/__mocks__/**/*', | ||
| './src/utils/storyUtils.ts', | ||
| './src/utils/testUtils.tsx', | ||
| ], |
There was a problem hiding this comment.
tsconfig.compile과 유사해 보이지만 tsconfig: tsconfig.compile.json 으로 설정하고 빌드 시 올바르게 동작하지 않습니다
Comment on lines
+8
to
+9
| // eslint-disable-next-line no-restricted-imports | ||
| import defaultAvatarUrl from '../assets/defaultAvatar.svg' |
There was a problem hiding this comment.
svg가 절대경로가 동작하지 않아 상대경로로 변경했습니다
|
🎉 This PR is included in version 1.0.0-next-v1.66 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rollup/plugin-alias를 제거하고 rollup-plugin-typescript2 를 사용하게 수정
Summary
#649 이후로 빌드시 결과물에 type definition file이 올바르게 되어있지 않아 사용처에서 타입 오류를 발생시키던 문제를 해결합니다
Details
#649에서는 @rollup/plugin-alias를 사용하여 절대경로를 설정했습니다.
이전까지의 빌드 방식에서 문제가 발생했는데, typescript를 통하여 타입을 생성하는 과정은 rollup bundling보다 먼저 일어나기 때문에 생성된 defiition file들이 상대 경로가 아닌 절대 경로로 타입이 잡히게 되는 문제가 일어났습니다.
typescript 만으로는 이를 해결할 수 없기 때문에 다른 plugin을 사용하여 해결했습니다.
rollup-plugin-typescript2는 가장 대중적으로 쓰이는 plugin이고, 아래 코멘트를 참고하여 해결했습니다
ezolenko/rollup-plugin-typescript2#201 (comment)
다음과 같이 번들링과 type definition 파일들이 잘 나오고, ch-desk-web에 설치해서도 확인했습니다
Browser Compatibility
OS / Engine 호환성을 반드시 확인해주세요.
Windows
macOS
References