Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Button component with scss #1882

Merged
merged 24 commits into from
Jan 9, 2024
Merged

Migrate Button component with scss #1882

merged 24 commits into from
Jan 9, 2024

Commits on Jan 5, 2024

  1. feat(button): add scss module

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    db56533 View commit details
    Browse the repository at this point in the history

  2. feat(button): apply scss module

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d0eeb36 View commit details
    Browse the repository at this point in the history

  3. refactor(button): modify the case of enum value for class names

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    6880a77 View commit details
    Browse the repository at this point in the history

  4. refactor(button): correctly narrowing the type of button type

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    41b7dbe View commit details
    Browse the repository at this point in the history

  5. refactor(button): defining type

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    dabb5c1 View commit details
    Browse the repository at this point in the history

  6. feat(button): fix styles

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    4563420 View commit details
    Browse the repository at this point in the history

  7. refactor(button): remove unnecessary memo

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    8a96bcf View commit details
    Browse the repository at this point in the history

  8. refactor(button): change render fn to component

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e300b84 View commit details
    Browse the repository at this point in the history

  9. refactor(button): remove unused props, etc

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    596fd98 View commit details
    Browse the repository at this point in the history

  10. refactor(button): refine type

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a48a72e View commit details
    Browse the repository at this point in the history

  11. refactor(button): convert default export to named export

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d9743b0 View commit details
    Browse the repository at this point in the history

  12. refactor(button): remove unnecessary return value

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    9aaa059 View commit details
    Browse the repository at this point in the history

  13. fix(button): pass missing classname prop and enhance to support commo… 

    …n margin props
    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    6393856 View commit details
    Browse the repository at this point in the history

  14. fix(button): remove unused styled file and snapshot test

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    dabf649 View commit details
    Browse the repository at this point in the history

  15. feat(button): shorten styles and improve focus styles

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    857f9af View commit details
    Browse the repository at this point in the history

  16. test: fix failed test cases

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1f47e1d View commit details
    Browse the repository at this point in the history

  17. fix(button): fix incorrectly applied margin styles

    @sungik-choi
    sungik-choi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    85006e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. refactor(button): rm unused named export

    @sungik-choi
    sungik-choi committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ae4f75f View commit details
    Browse the repository at this point in the history

  2. refactor(button): rm unnecessary type declaration

    @sungik-choi
    sungik-choi committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8e0792d View commit details
    Browse the repository at this point in the history

  3. chore(changeset): add changeset

    @sungik-choi
    sungik-choi committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4318257 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. refactor(button): remove layer at rule 

    channel-io#1887
    @sungik-choi
    sungik-choi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d095a3f View commit details
    Browse the repository at this point in the history

  2. fix(button): change focus ring style via outline

    @sungik-choi
    sungik-choi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    8b6e40f View commit details
    Browse the repository at this point in the history

  3. refactor(button): rm duplicated as const

    @sungik-choi
    sungik-choi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b648442 View commit details
    Browse the repository at this point in the history

  4. chore(changeset): fix typo

    @sungik-choi
    sungik-choi committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    56159b8 View commit details
    Browse the repository at this point in the history