Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency svgo to v3.0.4 #1739

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 20, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
svgo (source) 3.0.3 -> 3.0.4 age adoption passing confidence

Release Notes

svg/svgo (svgo)

v3.0.4

Compare Source

Includes various bug fixes for existing plugins and a new optimization. Also splits removeXMLNS, which removed XLink, into two separate plugins, removeXMLNS and removeXlink.

What's Changed

Default Behavior
Bug Fixes
SVG Optimization

Metrics

Before and after using vectors from various sources, with the default preset of each respective version:

SVG Original v3.0.3 v3.0.4 Delta
Arch Linux Logo 9.529 KiB 4.738 KiB 4.735 KiB ⬇️ 0.003 KiB
Blobs 50.45 KiB 42.949 KiB 42.949 KiB
Isometric Madness 869.034 KiB 550.699 KiB 550.593 KiB ⬇️ 0.106 KiB
tldr-pages Banner 2.071 KiB 1.07 KiB 1.07 KiB
Wikipedia Logo 161.552 KiB 118.441 KiB 117.152 KiB ⬇️ 1.289 KiB

Before and after of the browser bundle of each respective version:

v3.0.3 v3.0.4 Delta
svgo.browser.js 651.7 kB 656.9 kB ⬆️ 5.2 kB

Configuration

📅 Schedule: Branch creation - "on Monday after 10am before 7pm" in timezone Asia/Seoul, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the chore:deps Issue or PR related to dependencies label Nov 20, 2023
Copy link

changeset-bot bot commented Nov 20, 2023

⚠️ No Changeset found

Latest commit: 6588449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34c76bd) 87.41% compared to head (6588449) 87.41%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         281      281           
  Lines        3908     3908           
  Branches      822      822           
=======================================
  Hits         3416     3416           
  Misses        421      421           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi merged commit f9fccda into main Nov 22, 2023
11 checks passed
@sungik-choi sungik-choi deleted the renovate/svgo-3.x-lockfile branch November 22, 2023 02:35
yangwooseong added a commit that referenced this pull request Jan 10, 2024
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- None

## Summary
<!-- Please brief explanation of the changes made -->

- `ArrowRightUp` icon 이 깨지는 버그를 수정합니다. (**target branch: main**)


![image](https://github.com/channel-io/bezier-react/assets/28595102/31902bd8-d706-4ea0-bdbb-a5d4c3da7f0c)


## Details
<!-- Please elaborate description of the changes -->

- svgo 3.0.3 에서 빌드했을 때는 안깨지다가 3.0.4에서 빌드하면 깨지는 것으로 보아 svgo 라이브러리의 문제라고
추정됩니다.
- 최신 버전(3.2.0)에서 빌드하면 재현이 안되는 것을 확인했기 때문에 최신 버전으로 업그레이드 합니다. 빌드 결과는 커멘트로
달리는 스토리북 프리뷰를 참고해주세요.
- 시각 회귀 테스트가 잘 동작했다면 사전에 방지할 수 있었을 것으로 보입니다
(#1000)

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

- No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- svgo 3.0.3로 빌드한 스토리북 :
#1725 (comment)
- svgo 3.0.4로 빌드한 스토리북:
#1739 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore:deps Issue or PR related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant