Skip to content

Commit

Permalink
fix(key-value-item): add overflow hidden style to item wrapper element (
Browse files Browse the repository at this point in the history
#2036)

<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Summary
<!-- Please brief explanation of the changes made -->

fix(key-value-item): add overflow hidden style to item wrapper element

## Details
<!-- Please elaborate description of the changes -->

<img width="302" alt="스크린샷 2024-02-29 오후 2 49 11"
src="https://github.com/channel-io/bezier-react/assets/58209009/001883f3-ef32-49d9-acfe-d4f673ec0374">

scss 마이그레이션 과정에서 `overflow: hidden` 스타일이 제거되어 사용처(채널 데스크)에서 위와 같은 오버플로우
현상이 발생하는 문제를 수정합니다.

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No
  • Loading branch information
sungik-choi authored Mar 4, 2024
1 parent f6c3a88 commit 71a07de
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/selfish-turkeys-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@channel.io/bezier-react": patch
---

Add missing `overflow: hidden` style to item wrapper of `KeyValueItem` component.
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
}

.ItemWrapper {
overflow: hidden;
display: flex;
align-items: flex-start;

Expand Down

0 comments on commit 71a07de

Please sign in to comment.