Skip to content

Commit

Permalink
feat(overlay): rm unused wrapperTestId property
Browse files Browse the repository at this point in the history
  • Loading branch information
sungik-choi committed Jan 29, 2024
1 parent c0ee366 commit 4a540b7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 1 addition & 0 deletions .changeset/curly-poets-decide.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@

- No longer support `as` and `interpolation` property. Replace any usage of `interpolation` property with appropriate `style` or `className` implementations.
- No longer support `containerInterpolation` property. Replace any usage of `containerInterpolation` property with appropriate `containerStyle` or `containerClassName` implementations.
- No longer support `wrapperTestId` property.
7 changes: 1 addition & 6 deletions packages/bezier-react/src/components/Overlay/Overlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import { getOverlayStyle } from './utils'
import styles from './Overlay.module.scss'

export const CONTAINER_TEST_ID = 'bezier-react-container'
export const WRAPPER_TEST_ID = 'bezier-react-wrapper'
export const OVERLAY_TEST_ID = 'bezier-react-overlay'
export const ESCAPE_KEY = 'Escape'

Expand All @@ -54,7 +53,6 @@ export const Overlay = forwardRef<HTMLDivElement, OverlayProps>(function Overlay
containerStyle,
containerClassName,
containerTestId = CONTAINER_TEST_ID,
wrapperTestId = WRAPPER_TEST_ID,
onHide,
onTransitionEnd,
...rest
Expand Down Expand Up @@ -280,10 +278,7 @@ export const Overlay = forwardRef<HTMLDivElement, OverlayProps>(function Overlay
ref={containerRef}
data-testid={containerTestId}
>
<div
className={styles.OverlayWrapper}
data-testid={wrapperTestId}
>
<div className={styles.OverlayWrapper}>
{ Content }
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ export interface OverlayProps extends
AlphaBezierComponentProps,
ChildrenProps,
AlphaAdditionalStylableProps<'container'>,
AdditionalTestIdProps<['container', 'wrapper']>,
AdditionalTestIdProps<'container'>,
React.HTMLAttributes<HTMLDivElement>,
OverlayOwnProps {}

0 comments on commit 4a540b7

Please sign in to comment.