Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Bump suggested node version, add bin and license keys to package #1

Merged
merged 3 commits into from
Jun 1, 2016

Conversation

quaelin
Copy link
Member

@quaelin quaelin commented Jun 1, 2016

  • Bump the suggested Node version in .nvmrc to the latest, but leave the "engines" Node version as >=4.4.4 for broader compatibility.
  • Specify license as MIT. (Still need to finish code and legal review before we can make this public, though.)
  • Add "bin": "./index" to package.json, so that npm will install redis-key-scanner as an executable.

@erikogan @mertonium

@quaelin
Copy link
Member Author

quaelin commented Jun 1, 2016

Aha, and I was just reminded why I didn't have this running with Node 6.x. nodejs/node#6297 means that the console.log(usage) statement ends up getting truncated.

So for now, setting recommended version back to 4.4.5.

@erikogan
Copy link

erikogan commented Jun 1, 2016

I don’t think this should block release, but nodejs/node#6456 suggests a workaround to ensure that stdout/err get flushed before exit. We should probably look at setting them as blocking.

(Even though we recommend 4.4.5, people will run on whatever they have (or whatever is easiest to install, which would be latest))

@quaelin
Copy link
Member Author

quaelin commented Jun 1, 2016

Ok @erikogan, took your suggested workaround. I've confirmed it works with both 4.4.5 and 6.2.0.

@mertonium
Copy link

LGTM

@quaelin quaelin merged commit fd78dae into master Jun 1, 2016
@quaelin quaelin deleted the cc-polish branch June 1, 2016 18:31
@erikogan
Copy link

erikogan commented Jun 1, 2016

LGTM. @quaelin++ for no additional tech-debt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants