Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fedora 35 as base image to benefit GHC 8.10 #647

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Use Fedora 35 as base image to benefit GHC 8.10 #647

merged 1 commit into from
Oct 12, 2021

Conversation

morucci
Copy link
Collaborator

@morucci morucci commented Oct 11, 2021

We are hitting:

src/Data/Primitive/Contiguous/Class.hs:11:14: error:
Unsupported extension: UnliftedNewtypes
Perhaps you meant ‘UnliftedFFITypes’

Copy link
Contributor

@TristanCacqueray TristanCacqueray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to force the builder image to be built in the CI before the compose, otherwise we may be using the old version, resulting in incompatible libc or something.

Otherwise we could update the builder first, then rebase this PR.

@morucci
Copy link
Collaborator Author

morucci commented Oct 11, 2021

Ok, #649

@morucci
Copy link
Collaborator Author

morucci commented Oct 11, 2021

#649 merged but the action fails badly https://github.com/change-metrics/monocle/runs/3861582837?check_suite_focus=true
I guess that's a transient issue.
I that still happen I'll build locally and push manually.

@morucci
Copy link
Collaborator Author

morucci commented Oct 11, 2021

I'll check this actions/runner-images#3812 as it seems to be a known issue.

@TristanCacqueray
Copy link
Contributor

Oh makes sense, then let's try to install the patched docker version in the monocle actions.

We are hitting:

src/Data/Primitive/Contiguous/Class.hs:11:14: error:
    Unsupported extension: UnliftedNewtypes
    Perhaps you meant ‘UnliftedFFITypes’

Also update github action to use stock docker engine, see:
#652
@morucci morucci added the merge me Trigger the merge process label Oct 12, 2021
@morucci morucci merged commit f40dbcd into change-metrics:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants