This repository has been archived by the owner on Jul 23, 2021. It is now read-only.
lentille-github: Fix decoding issue for URI type #15
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures the URI Text where Text is JSON doc (eg. newTaskDataChangeUrl = "URI \"https://github.com/elastic/elasticsearch/pull/72808\"") is decoded.
| @@ -159,7 +160,11 @@ transformResponse searchResult = | |||
| extractUrl item = case item of | |||
| Just | |||
| ( SearchNodesTimelineItemsNodesConnectedEvent | |||
| (SearchNodesTimelineItemsNodesSubjectPullRequest (url)) | |||
| ) -> show url | |||
There was a problem hiding this comment.
The show implementation for Text does adds quotes. I don't think we need to further decode the value and unwrapping the URI type may be enough:
(SearchNodesTimelineItemsNodesSubjectPullRequest (URI url))) -> url
|
No it was not enough. I tried it. It was still quoted.
Le dim. 16 mai 2021 à 23:36, Tristan de Cacqueray ***@***.***>
a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In lentille-github/src/Lentille/GitHub/Issues.hs
<#15 (comment)>
:
> @@ -159,7 +160,11 @@ transformResponse searchResult =
extractUrl item = case item of
Just
( SearchNodesTimelineItemsNodesConnectedEvent
- (SearchNodesTimelineItemsNodesSubjectPullRequest (url))
- ) -> show url
The show implementation for Text does adds quotes. I don't think we need
to further decode the value and unwrapping the URI type may be enough:
(SearchNodesTimelineItemsNodesSubjectPullRequest (URI url))) -> url
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#15 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUUZ7BKK6MRJU6VAFTBKTTOA3HFANCNFSM44SHRXZQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures the URI Text where Text is JSON doc (eg.
newTaskDataChangeUrl = ""https://github.com/elastic/elasticsearch/pull/70392\"")
is decoded.