Fix for CheckFixedFld hoisting bug OS:6773420 #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoist CheckObjType, and don't hoist propertySym opnd if type is checked. It break obj type spec and has no benefits.
|
@pleath and @MikeHolman, please review. |
|
LGTM. |
chakrabot
pushed a commit
that referenced
this pull request
Apr 13, 2016
Merge pull request #787 from LouisLaf:inv_bug Hoist CheckObjType as well since there is a dependency with CheckFixedFld, and don't hoist propertySym opnd if type is checked. It break obj type spec and has no benefits.
chakrabot
pushed a commit
that referenced
this pull request
Apr 13, 2016
Merge pull request #787 from LouisLaf:inv_bug Hoist CheckObjType as well since there is a dependency with CheckFixedFld, and don't hoist propertySym opnd if type is checked. It break obj type spec and has no benefits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist CheckObjType as well since there is a dependency with CheckFixedFld, and
don't hoist propertySym opnd if type is checked. It break obj type spec and has no benefits.