Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune Number.toString conversion to be more like in Chrome #4877

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Tune Number.toString conversion to be more like in Chrome #4877

merged 1 commit into from
Mar 27, 2018

Conversation

IrinaYatsenko
Copy link
Contributor

Fixes #2512. This change doesn't make out Number.toString to produce the same output as Chrome does, but gets it a bit more aligned.

@IrinaYatsenko IrinaYatsenko changed the title Tune conversion to be more like in Chrome Tune Number.toString conversion to be more like in Chrome Mar 26, 2018
MSLaguana
MSLaguana approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@MSLaguana MSLaguana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like if we did decide to round x.599999 to x.6 or equivalent it would be fairly simple to adapt the section that trims trailing 0s, but I'm happy to leave that for future debate.

sethbrenith
sethbrenith approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@sethbrenith sethbrenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chakrabot chakrabot merged commit a16136d into chakra-core:master Mar 27, 2018
chakrabot pushed a commit that referenced this pull request Mar 27, 2018
[MERGE #4877 @irinayat-MS] Tune Number.toString conversion to be more…
1444318 
… like in Chrome

Merge pull request #4877 from irinayat-MS:float_toString

Fixes #2512. This change doesn't make out Number.toString to produce the same output as Chrome does, but gets it a bit more aligned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSLaguana MSLaguana MSLaguana approved these changes

@sethbrenith sethbrenith sethbrenith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IrinaYatsenko @sethbrenith @MSLaguana @chakrabot