swb: run write-barrier check/analyze from build.sh #1735
Conversation
| // Copyright (C) Microsoft. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information. | ||
| //------------------------------------------------------------------------------------------------------- | ||
|
|
||
| //===- RecyclerChecker.cpp ---------------------------------------------===// |
There was a problem hiding this comment.
I think this license is from the original sample I was working off of- I don't know if it needs to be preserved since this code is considerably different than the sample. In any case, the comment following the license should be fixed :)
There was a problem hiding this comment.
@digitalinfinity I'll remove the old license then. How about the 2 modules/Find???.cmake files? Do they need any license copy, or should we insert our license? (I'm currently excluding them from Jenkins.)
Revert enabling GLOBAL_FORCE_USE_WRITE_BARRIER on Windows. That should be a test feature and also not ready to turn on. `template<ObjectInfoBits>` does not accept `library->Enum...` for instantiation. Should use `JavascriptLibrary::Enum...`. Fix a few assertions. Fix one case of `insertBeforeInstr/assignInstr` name regression.
Also fix tab check.
Enable build.sh to run write-barrier check/analyze: ``` build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp ```
| @@ -154,8 +154,6 @@ | |||
| #ifdef RECYCLER_WRITE_BARRIER | |||
| #if defined(__clang__) | |||
| #define GLOBAL_FORCE_USE_WRITE_BARRIER 1 | |||
| #else | |||
| #define GLOBAL_FORCE_USE_WRITE_BARRIER 1 // force turn on write barrier in windows | |||
There was a problem hiding this comment.
1 [](start = 39, length = 2)
change to 0 instead of removing it? when we want to test it windows it's easier to turn on
There was a problem hiding this comment.
You can just go to line 155 and do #if 1 //defined...
There was a problem hiding this comment.
Or the force on windows functionality should be from a command line switch and populate here?
AsmJsModule.cpp calls TypedArray<..., true>::Create and results in link error because the implementation is in cpp file and no explicit instantiation. Also it would miss constructor implementation for the same reason. Fixed by moving both constructor and Create template implementations to header file.
|
@dotnet-bot test linux tests please |
|
|
…ld.sh Merge pull request #1735 from jianchun:swbscript Enable build.sh to run write-barrier check/analyze: ``` build.sh -n -d --wb-check lib/Runtime/Base/FunctionBody.cpp ``` Also fix some build breaks and failures/assertions, fix copyright headers and tabs.
Enable build.sh to run write-barrier check/analyze: