Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/page for block height #162

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Feature/page for block height #162

merged 4 commits into from
Nov 13, 2023

Conversation

Yamaguchi
Copy link
Contributor

resolve #91

  • Add new routing to page for block information with a specified height
    • GET /block/height/:height
  • Add query parameter page to block list page
    • GET /blocks?page=:page

@Yamaguchi Yamaguchi force-pushed the feature/page_for_block_height branch from 43633eb to ed4e528 Compare October 27, 2023 10:34
Copy link
Contributor

@rantan rantan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ページネーションボタンを押したときも page=1 の数字が表示されるページに切り替わる方が良いと思いました。
今の挙動だと最初に開いた時のページ番号のままなのでわかりにくく思います。

@Yamaguchi Yamaguchi force-pushed the feature/page_for_block_height branch from 930600e to e4bc559 Compare November 8, 2023 08:56
@Yamaguchi Yamaguchi force-pushed the feature/page_for_block_height branch from e4bc559 to e9bce22 Compare November 8, 2023 09:00
@rantan rantan merged commit ee92977 into master Nov 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I wanna show specific block height pages
2 participants