Improve extracted archive file clean up #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
egibs
force-pushed
the
fix-temp-file-removal
branch
from
a15f3e5 to
bad2b00
Compare
tstromberg
pushed a commit
to tstromberg/malcontent
that referenced
this pull request
Dec 17, 2024
* Improve extracted archive file clean up Signed-off-by: egibs <[email protected]> * Wrap tmpRoot removal in a defer instead Signed-off-by: egibs <[email protected]> * Only remove if tmpRoot is created successfully Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
tstromberg
added a commit
that referenced
this pull request
Dec 17, 2024
* Add exception for SonarAnalyzer.CSharp.dll * Improve extracted archive file clean up (#714) * Improve extracted archive file clean up Signed-off-by: egibs <[email protected]> * Wrap tmpRoot removal in a defer instead Signed-off-by: egibs <[email protected]> * Only remove if tmpRoot is created successfully Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]> * Add tests * update testdata --------- Signed-off-by: egibs <[email protected]> Co-authored-by: Evan Gibler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #711
This PR ensures that
tmpRootis removed beforeprocessArchivereturns (and only iftmpRootis not""). Previously, we would only remove the directory if no errors were encountered during scanning.