Use 8-core runners for tests and updating third-party rules #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
tstromberg
approved these changes
Nov 16, 2024
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Nov 16, 2024
…rd-dev#633) * Use 8-core runners for tests and updating third-party rules Signed-off-by: egibs <[email protected]> * Update TestCleanPath to run its cases in parallel Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all of our tests using
t.Parallel()appropriately, we can leverage a larger runner to further cut down on how long our tests take.Based on #632, 8-core runners offer a sizable performance uplift over the default 4-core runners and anything larger hits the realm of diminishing returns pretty quickly.
This definitely beats the 12-13+ minute Workflow runs we were seeing originally.
Bonus third-party rule Workflow timing after the change (ten minutes faster!):
