Explicitly check for "mal" binary name when ignoring self #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
egibs
changed the title
ajayk
approved these changes
Sep 23, 2024
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
…-dev#466) Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #464, I used the full
malcontentstring when checking whether the Rule name and metadata were formalcontentrather than justmalin the event we had other partialmalstring matches in the future.Since the
malcontentbinary ismal, thefilepath.Base(path) == NAMEcheck was failing becausemal!=malcontent.This PR explicitly checks whether
filepath.Base(path)ismal. I tested this locally and the ignore behavior worked as expected.I'll cut
1.0.1to get this out before merging wolfi-dev/os#29171.