-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul CLI functionality with urfave/cli #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
force-pushed
the
better-cli
branch
2 times, most recently
from
September 4, 2024 13:50
fbc78a0
to
4484e63
Compare
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
tstromberg
reviewed
Sep 11, 2024
Signed-off-by: egibs <[email protected]>
tstromberg
approved these changes
Sep 11, 2024
Signed-off-by: Evan Gibler <[email protected]>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Overhaul CLI functionality with urfave/cli Signed-off-by: egibs <[email protected]> * Use flags to separate image/path scanning Signed-off-by: egibs <[email protected]> * Small tweaks Signed-off-by: egibs <[email protected]> * Update test data refresh script, handle scan edge cases Signed-off-by: egibs <[email protected]> * Simplify risk level map Signed-off-by: egibs <[email protected]> * Update wording/formatting Signed-off-by: egibs <[email protected]> * Clean up arg parsing Signed-off-by: egibs <[email protected]> * Clean up version string Signed-off-by: egibs <[email protected]> * Add separate analyze command for displaying all rule matches Signed-off-by: egibs <[email protected]> * Appease the linter Signed-off-by: egibs <[email protected]> * Scan flag is not needed Signed-off-by: egibs <[email protected]> * Filter out < 3 risk scores when running a scan Signed-off-by: egibs <[email protected]> * Severity -> risk Signed-off-by: egibs <[email protected]> * Only require flags for analyzing/scanning images Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]> Signed-off-by: Evan Gibler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usage of the
flags
package was struggling with the amount of functionality introduced over the past several months.This PR moves to the
urfave/cli
package for the CLI functionality and focuses on:scan
anddiff
commandsscan
The changes in this PR will be breaking (as evidenced by the updated
refresh-testdata.sh
script); however, there is some flexibility around specifying thescan
flags. Omitting the flags will default to the original path scanning behavior (i.e., non-image scans). Otherwise, specifying-i
will scan OCI images and-p
will scan a local file path.The new use looks like this:
To view the flags:
To view command help:
To view the version: