Update to go1.22; speed up recursiveScan #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
|
I may tweak the concurrency a bit tomorrow. |
|
Let's use go1.23 which is already available! |
|
I'm going to break this PR apart -- one for the updates and another for performance/feature work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Go 1.23.0 being released, I figured it was time for us to update bincapz to 1.22. This PR handles the Go update along with package updates, including
clogwhich requires Go 1.22.I also updated the
slogtest.TestContextWithLoggercalls toslogtest.Contextinsamples_test.go.Additionally, I add some concurrency to
recursiveScanwhich makes quite a big impact when scanning numerous directories/files:main:goos: linux
goarch: amd64
pkg: github.com/chainguard-dev/bincapz/samples
cpu: AMD Ryzen 7 7840U w/ Radeon 780M Graphics
BenchmarkRun-16 1 83237798093 ns/op 761214920 B/op 4789175 allocs/op
PASS
ok github.com/chainguard-dev/bincapz/samples 83.323s
New code:
goos: linux
goarch: amd64
pkg: github.com/chainguard-dev/bincapz/samples
cpu: AMD Ryzen 7 7840U w/ Radeon 780M Graphics
BenchmarkRun-16 1 50308758726 ns/op 762749936 B/op 4789434 allocs/op
PASS
ok github.com/chainguard-dev/bincapz/samples 50.402s
We're still hitting single-threaded bottlenecks during certain portions of the code execution so I'm tracking those down.