Address more run-tests.php false positives #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
hectorj2f
approved these changes
Jul 30, 2024
egibs
changed the title
9 tasks
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
* Address PHP run-tests.php false positives Signed-off-by: egibs <[email protected]> * Refresh test data Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Address PHP run-tests.php false positives Signed-off-by: egibs <[email protected]> * Refresh test data Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses additional false positives seen in the
run-tests.phpfile (which we have a sample for):The sample results reflect the false positive being removed with these tweaks.