Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SIGNATURE_BASE_SUSP_PS1_JAB_Pattern_Jun22_1 rule #355

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

egibs
Copy link
Member

@egibs egibs commented Jul 11, 2024

This rule is causing false positives: wolfi-dev/os#23799

This PR turns the rule off (since it's a third-party rule we can't modify it directly); however, we can potentially roll our own rule for this in the future and add exclusions.

@egibs egibs requested a review from tstromberg July 11, 2024 21:08
"GODMODERULES_IDDQD_God_Mode_Rule": true,
"MALPEDIA_Win_Unidentified_107_Auto": true,
"GCTI_Sliver_Implant_32Bit": true,
"SIGNATURE_BASE_SUSP_PS1_JAB_Pattern_Jun22_1", true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only addition.

The rest of the changes are from sorting all of the lines.

Signed-off-by: egibs <[email protected]>
@egibs egibs merged commit 8c46f3d into chainguard-dev:main Jul 11, 2024
6 checks passed
@egibs egibs deleted the turn-off-JAB_Pattern_Jun22_1 branch July 19, 2024 13:20
egibs added a commit to egibs/malcontent that referenced this pull request Aug 5, 2024
…ev#355)

* Ignore SIGNATURE_BASE_SUSP_PS1_JAB_Pattern_Jun22_1 rule

Signed-off-by: egibs <[email protected]>

* make fix

Signed-off-by: egibs <[email protected]>

---------

Signed-off-by: egibs <[email protected]>
egibs added a commit to egibs/malcontent that referenced this pull request Sep 25, 2024
…ev#355)

* Ignore SIGNATURE_BASE_SUSP_PS1_JAB_Pattern_Jun22_1 rule

Signed-off-by: egibs <[email protected]>

* make fix

Signed-off-by: egibs <[email protected]>

---------

Signed-off-by: egibs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants