Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve datadog-agent DDOS false positive #299

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Resolve datadog-agent DDOS false positive #299

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad56581
Avoid datadog-agent DDOS false positive
egibs Jun 29, 2024
98a600c
Make ignore more generic
egibs Jun 29, 2024
e548892
Revert to exact DataDog reference
egibs Jul 1, 2024
e1c62dd
Merge branch 'main' into remove-dd-agent-false-positive
egibs Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rules/net/ddos.yara
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

rule ddos_refs : critical {
meta:
description = "Performs DDoS (distributed denial of service) attacks"
Expand All @@ -9,6 +8,8 @@ rule ddos_refs : critical {
$ref = "TSource Engine Query"
$ref2 = "ackflood" fullword
$ref3 = "synflood" fullword
// datadog-agent tracer-fentry-debug.o
$ignore_ref = /synflood\_\w+/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this is too generic of an ignore, and will result in missing hits. Can you find something more specific to datadog-agent - maybe the exact phrase used for synflood_xxx?

Also, please use {0,256} instead of +, as unbounded matches have severe performance impacts in YARA.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do -- I'll go back and limit any other unbounded changes in the other open PRs as well.

condition:
any of them
any of ($ref*) and not $ignore_ref
}