Release/Tag Workflow followup fixes #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
egibs
force-pushed
the
release-workflow-followup
branch
from
c921984 to
d2cdeea
Compare
egibs
commented
Jun 9, 2024
| exit 0 | ||
| else | ||
| git config --global tag.gpgsign true |
There was a problem hiding this comment.
This is mentioned in the default Gitsign configuration: https://github.com/sigstore/gitsign?tab=readme-ov-file#configuration
However, the Action does not currently configure this:
https://github.com/chainguard-dev/actions/blob/e82b4e5ae10182af72972addcb3fedf7454621c8/setup-gitsign/action.yml#L103-L111
There was a problem hiding this comment.
Opened a PR to add git config --global tag.gpgsign true to the Action: chainguard-dev/actions#442
tstromberg
approved these changes
Jun 10, 2024
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
Signed-off-by: egibs <[email protected]>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few tweaks/additions:
sed -iinstead ofsed -i''(MacOS testing artifact)gitsign)Original errors:
