Rule improvements based on temporal analysis #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaikas
approved these changes
May 2, 2024
egibs
pushed a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
egibs
pushed a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: wolfi-dev/os#18069
Some versions of temporal ships with "/etc/services" and "/etc/protocols" files intact, which produced a number of false positives.
The "lockedFiles" rule was intended to catch ransomware, but it was found to match some lock file implementations. In temporal's case, it was due to https://gitlab.com/cznic/libc/-/blob/master/libc_musl.go#L561 - which is a dep of the sqlite implementation temporal uses.