Make sure list of 'repositories' in the 'resolved.json.file' is complete. #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ptabor
force-pushed
the
20231211-all-repositories
branch
3 times, most recently
from
7d6fb0b
to
ee83d80
Compare
…ete. Prior to this PR, there were only listed used repositories by any of the artifact for given arch. On the other hand the list was used to run APKO in off-line environment -> and missing repos were leading to failure (in rules_apko). Eventually repositories and indexes will not be needed for creation of image from resolved file, but, if we have the list in the file-format -> it should be complete. Signed-off-by: Piotr Tabor <[email protected]>
sfc-gh-ptabor
force-pushed
the
20231211-all-repositories
branch
from
ee83d80
to
6f80ac6
Compare
Signed-off-by: Jason Hall <[email protected]>
imjasonh
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure list of 'repositories' in the 'resolved.json.file' is complete.
Prior to this PR, there were only listed used repositories used by any of the artifacts for given arch.
On the other hand the list was used to run APKO in offline environment -> and missing repos were leading to a failure
(in rules_apko).
Eventually repositories and indexes will not be needed for creation of image from resolved file, but, if we have the list in the file-format -> it should be complete.