-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement resolve command #902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
apko-resolve
branch
from
September 28, 2023 23:16
ad97a58
to
a18921c
Compare
imjasonh
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few small comments, this looks really good.
Sorry for the delay in reviewing it.
thesayyn
force-pushed
the
apko-resolve
branch
from
October 11, 2023 19:21
a18921c
to
7f1b75e
Compare
imjasonh
reviewed
Oct 16, 2023
imjasonh
reviewed
Oct 16, 2023
thesayyn
force-pushed
the
apko-resolve
branch
2 times, most recently
from
October 16, 2023 21:35
80e7bc5
to
39ade65
Compare
@imjasonh could you kick the CI? |
Signed-off-by: thesayyn <[email protected]>
thesayyn
force-pushed
the
apko-resolve
branch
from
October 16, 2023 21:38
39ade65
to
ba38ba0
Compare
fixed the lint. need the CI run again. |
@imjasonh could you please run the ci again? |
imjasonh
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.