Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gorelease to use the sign step to sign the build artifacts #16

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 24, 2022

  • update gorelease to use the sign step to sign the build artifacts

rehearsal: https://github.com/cpanato/apko/releases/tag/v99.99.99

my question is we will distribute the tar.gz it is not easier just the binary? otherwise, the user needs to download and unpack it just to get one file (besides the license)

follow up of https://github.com/chainguard-dev/apko/pull/15/files

cc @kaniini @mattmoor

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: .tar.gz vs. binary, I'm fine with either, I was just copying what I did in mattmoor/mink ages ago (which I think I copied from elsewhere).

@cpanato
Copy link
Member Author

cpanato commented Feb 24, 2022

any thoughts @kaniini ?

@kaniini kaniini merged commit 98e1549 into chainguard-dev:main Feb 24, 2022
@cpanato cpanato deleted the update-goreleaser branch February 24, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants