Stop using real headers for side channels #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it was clever to use If-None-Match because it was pretty close to what I wanted, but the way we're wrapping transports means that this actually breaks if the Etag matches. Whoops! Just change this to an invalid header so that this stops breaking, we can fix it better later by making the cache not look like a transport. Signed-off-by: Jon Johnson <[email protected]>
luhring
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it was clever to use If-None-Match because it was pretty close to what I wanted, but the way we're wrapping transports means that this actually breaks if the Etag matches. Whoops!
Just change this to an invalid header so that this stops breaking, we can fix it better later by making the cache not look like a transport.