Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBOM test cleanup #1361

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

luhring
Copy link
Contributor

@luhring luhring commented Oct 24, 2024

The SBOM code is not in great shape and needs some work. So too do the tests for this code, which needs attention first, because without good tests, we can't confidently refactor the core business logic.

This PR makes progress on cleaning up the SBOM test code so that it's easier to work on it.

  • testdata files are organized with paths that explain their role in the tests (APK vs. image SBOMs)
  • Table-driven tests are used instead of duplicated test logic
  • Unnecessary test structs are removed

@luhring luhring changed the title Apko SBOM test cleanup SBOM test cleanup Oct 24, 2024
@imjasonh imjasonh merged commit 2566549 into chainguard-dev:main Oct 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants