Implement client-side APK discovery in apko
#1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol follows a roughly similar handshake to OIDC discovery, hitting `{repository}/apk-configuration`, extracting the `jwks_uri` and then recording each pem-encoded key as `/etc/apk/keys/{kid}.rsa.pub`.
Signed-off-by: Matt Moore <[email protected]>
imjasonh
reviewed
Jul 23, 2024
|
@imjasonh I made it do a real key discovery to confirm things work against staging. We can swap this to a prod group once we push. |
Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
apk-key-discovery
branch
from
c17b15e
to
c3ba50a
Compare
imjasonh
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol follows a roughly similar handshake to OIDC discovery, hitting
{repository}/apk-configuration, extracting thejwks_uriand then recording each pem-encoded key as/etc/apk/keys/{kid}.rsa.pub.I have tested this locally with both public and private APK repositories against
apk.mattmoor.devwith the changes in: https://github.com/chainguard-dev/mono/pull/18431Once this lands, I can use this in e2e tests there, but those are somewhat 🐔 & 🥚