fix: failing proof verification for blob transaction #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is implicitly part of the whole e2e test to verify merkle multiproofs
estensen
approved these changes
Nov 27, 2024
merklefruit
requested changes
Nov 27, 2024
Co-authored-by: merklefruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419.
The issue was in the encoding logic of type 3 transactions to compute the proof data, regardless on whether they had a sidecar or not.
In short, we were incorrectly discarding the signature fields before doing the EIP-2718 encoding to retrieve the raw bytes needed to compute the hash tree root of the transaction.
Computing an hash tree root with the wrong digest results in incorrectly computed leaves, as such proof verification was failing.
The PR adds also a test that runs in CI that verifies the process is carried out correctly, by loading test data correctly produced by the bolt-builder.